std.math.sign: Narrow integer return types to possible values
#23595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayschwa
force-pushed
the
narrow-math-sign-ints
branch
2 times, most recently
from
b35e4ce to
09f03f6
Compare
This may be a breaking change for callers that depend on the return type being identical to the input type. For example, `sign(i32) * i8 + i8` could now overflow. Callers can add an explicit type annotation to avoid that situation. If Zig ever allows small integer types to coerce to floats (see ziglang#18614), then it might make sense to always return an integer. In the meantime, I figured it would be too annoying for users dealing with floats.
jayschwa
force-pushed
the
narrow-math-sign-ints
branch
from
09f03f6 to
8f7598e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be a breaking change for callers that depend on the return type being identical to the input type. For example,
sign(i32) * i8 + i8could now overflow. Callers can add an explicit type annotation to avoid that situation.If Zig ever allows small integer types to coerce to floats (see #18614), then it might make sense to always return an integer. In the meantime, I figured it would be too annoying for users dealing with floats.